Conversation
|
@0xallam is ready for review |
|
Hi @Saedbhati, I reviewed your PR. Overall it looks good, but what’s implemented is materially different from the feature/issue description. The current approach adds an MCP client so Strix can connect to external tools/MCP servers. While that can be useful in some contexts, I don’t think it’s necessary for us right now - most of the core tools we’d want (Python, terminal, web search/browser, etc.) are already built into Strix. Adding an MCP client at this stage may also increase surface area and potentially confuse the agent without a clear benefit. What the issue/feature is actually asking for is the opposite: we need Strix to act as an MCP server. That would allow Strix to be used as a tool by other agents (e.g., Cursor, Codex, etc.) and make integration much simpler. If you’re open to it, I’d recommend re-scoping the PR in that direction |
fixes #109